Skip to content

Add comment warning about indexed DB atomicity #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 102 commits into
base: auth-next
Choose a base branch
from
Open

Add comment warning about indexed DB atomicity #3826

wants to merge 102 commits into from

Conversation

sam-gc
Copy link
Contributor

@sam-gc sam-gc commented Sep 22, 2020

sam-gc and others added 30 commits September 1, 2020 09:49
@sam-gc
Initial submit of auth-next framework (#2851)
031d9c1 
Initial package structure--copied from packages/template, but with tests working
@sam-gc
Add mock fetch helper (#2878)
a87602c 
Add mock fetch library for tests
@avolkovi @sam-gc
Add core types & error map to auth-exp (#2890)
ac7c1cd 
* Add core types & error map

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: License Headers

* User should be an interface for now

we can make an implementation class later
@avolkovi @sam-gc
Add signUp API method for auth-next (#2892)
f2aaa25 
* User should be an interface for now

we can make an implementation class later

* Add API call to signUp

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: License Headers

* Update tests to test a little more

* [AUTOMATED]: Prettier Code Styling
@sam-gc
Add initial user object implementation (#2896)
0fab943 
* Initial user object implementation
@sam-gc
Consolidate mock auth object, add user object (#2906)
3ebf112 
* Consolidate mock auth / add user test helper

* [AUTOMATED]: Prettier Code Styling

* Fix tests
@avolkovi @sam-gc
Add remaining API methods to auth-next (#2901)
3d433f0 
* User should be an interface for now

we can make an implementation class later

* Add API call to signUp

* [AUTOMATED]: Prettier Code Styling

* Update tests to test a little more

* Add remaining API methods to auth-next

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: License Headers

* Add more tests to account API methods

* Pass in SDK version & correctly send GET request params

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: Prettier Code Styling

* Fix import ordering

* Minor formatting change

* [AUTOMATED]: Prettier Code Styling
@avolkovi @sam-gc
Add support for API timeouts to auth-next (#2915)
875b1d1 
* Add support for API timeouts to auth-next

* PR feedback

* [AUTOMATED]: Prettier Code Styling
@avolkovi @sam-gc
Add version helpers to auth-next (#2910)
b6fbb5d 
* Add version helper to auth-next

* [AUTOMATED]: Prettier Code Styling

* PR feedback
@sam-gc
Add persistence layer: index db, in memory, and browser{local, sessio…
a00e204 
…n} (#2908)
@avolkovi @sam-gc
Add fetchSignInMethodsForEmail to auth-next (#2924)
3cbbc8e 
* Add fetchSignInMethodsForEmail to auth-next

* [AUTOMATED]: Prettier Code Styling

* PR Feedback

* [AUTOMATED]: Prettier Code Styling
@avolkovi @sam-gc
Add sendEmailVerification to auth-next (#2926)
dd06ad3 
* Add sendEmailVerification to auth-next

* [AUTOMATED]: Prettier Code Styling

* Add missing test

* Remove GetOobCodeRequestType in favor of Operation
@sam-gc
Add a persistence manager class (#2925)
8704910
@scottcrossen @sam-gc
Added react native build target (#2947)
af819d4
@avolkovi @sam-gc
Add password reset methods to auth-next (#2928)
b98942f 
* Add sendEmailVerification to auth-next

* [AUTOMATED]: Prettier Code Styling

* Remove GetOobCodeRequestType in favor of Operation

* Add password reset methods to auth-next

* [AUTOMATED]: Prettier Code Styling

* PR Feedback

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: Prettier Code Styling

* Resolve merge conflicts

* [AUTOMATED]: Prettier Code Styling
@avolkovi @sam-gc
use queryString helper in auth-next (#2936)
90060ea 
* Use queryString from firebase/util instead of homebrew one

* [AUTOMATED]: Prettier Code Styling

* PR Feedback

* [AUTOMATED]: Prettier Code Styling
@sam-gc
Initial auth object implementation + initializeAuth() (#2932)
8076912
@Feiyang1 @sam-gc
use app-exp in the build:deps script
3e72cc4
@avolkovi @sam-gc
Add conditional delays to auth-next (#2934)
b89468d 
* Add conditional delays to auth-next

* [AUTOMATED]: Prettier Code Styling

* Use typescript asserts keyword for typesafe assertions

* [AUTOMATED]: Prettier Code Styling

* Rebase conflicts & PR feedback

* More PR Feedback

* Strip debug asserts from prod builds

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: API Reports

* Fix logic in assertion

* Revert merge artifacts

* PR Feedback
@avolkovi @sam-gc
Add sendSignInWithEmail to auth-next (#2960)
3759e9c 
* Add sendSignInWithEmail links

* [AUTOMATED]: Prettier Code Styling

* PR Feedback

* PR Feedback
@sam-gc
Add auth listener implementation, add user.reload() (#2961)
dfea326
@avolkovi @sam-gc
Standardize auth-next style (#2983)
fdffefe 
* Standardize auth-next style

- prefix directory for test blocks
- use kebab style for test values to make them visually distinct from
keys
- use '#' to prefix instance methods and '.' for class methods
- prefix all private exported methods with '_'

* [AUTOMATED]: Prettier Code Styling

* Two more cases I missed
@sam-gc
Add refresh token endpoint + implementation to token manager (#2975)
7706df8
@scottcrossen @sam-gc
Add react native persistence class (#2955)
b8977fe 
Added React Native persistence class
@sam-gc
Add getIdTokenResult implementation (#3014)
91f17d4
@sam-gc
Update internal types to work with external types (#3075)
218af1d 
* Update internal types to work with external types

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: License Headers

* PR feedback

* [AUTOMATED]: Prettier Code Styling
@sam-gc
Further refactoring of auth types. Add public exports to src/index.ts (…
31d8f1c 
…#3078)

* Further refactoring of auth types. Add public exports to src/index.ts

* Add app-exp to devDependencies

* PR feedback
@sam-gc
user.delete() implementation (#3072)
ebfbaf8 
* user.delete() implementation

* [AUTOMATED]: Prettier Code Styling

* PR feedback

* PR feedback
@sam-gc
Use auth impl object instead of mock auth object (#3098)
6f12bd7
@avolkovi @sam-gc
Add signInWithCredential to auth-next (#2963)
95bc5d0 
* Add signInWithCredential to auth-next

* [AUTOMATED]: Prettier Code Styling

* Add conditional delays to auth-next (#2934)

* Add conditional delays to auth-next

* [AUTOMATED]: Prettier Code Styling

* Use typescript asserts keyword for typesafe assertions

* [AUTOMATED]: Prettier Code Styling

* Rebase conflicts & PR feedback

* More PR Feedback

* Strip debug asserts from prod builds

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: API Reports

* Fix logic in assertion

* Revert merge artifacts

* PR Feedback

* Cleanup & PR Feedback

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: License Headers

* Add more tests

* [AUTOMATED]: Prettier Code Styling

* Rebase conflicts

* Cleanup type exports

* PR feedback

* Declare abstract class abstractly
sam-gc and others added 15 commits September 1, 2020 09:54
@sam-gc
Add the internal auth interface including proactive refresh (#3655)
86261da 
* Proactive refresh and internal SDK

* Fix tests for node

* Formatting

* Remove unused file

* PR feedback

* Formatting
@avolkovi @sam-gc
Implement cross-window browser events for auth-next (#3631)
638219b 
* Implement cross-window browser events for auth-next

* Split out local & session storage

* Add persistence events to indexed DB

* Add some tests & fix a couple issues with local storage events

* Add tests for AuthImpl._onStorageEvent and fix getIdToken to trigger
correctly

* Merge conflicts

* PR feedback
@Feiyang1 @sam-gc
Auth next build (#3654)
e34b4b8 
* update package.json

* make internal and main share code

* remove unused deps and files

* point to the right typing file for internal

* cast internal Auth to public Auth to make TS happy
@sam-gc
yarn.lock
7689be9
@sam-gc
Fix the broken build. (#3717)
3f285d7 
* Fix the broken build

* Formatting

* Fix compat build

* Re-add demo

* Fix build errors

* Formatting

* Fix linting for auth-compat-exp
@sam-gc
Add hooks into auth-next for emulator config (#3716)
f9e48e0 
* Add hooks into emulator for auth-next

* Formatting

* PR feedback

* Fix broken tests

* Formatting
@sam-gc
Add assertions for type of OAuthProvider in popup/redirect (#3720)
2c40057 
* Add assertion for the oauthprovider type in popup/redirect

* Formatting
@sam-gc
Remove circular dependency issue with AuthCredential (#3718)
80d67c7 
* Fix circular dependency issue

* Formatting
@sam-gc
Add origin validation to popup/redirect flows (#3730)
4d9dc69 
* Add origin validation to the popup/redirect flows

* Formatting

* Cache the origin validation promise

* Formatting

* PR feedback

* Formatting
@sam-gc
Put some guardrails around the recaptcha host language param (#3734)
ced51d0 
* Add some guardrails for recaptcha host language param

* Formatting
@Feiyang1
Prepare auth-next for merging to master (#3740)
603cd87 
* suppress eslint error

* fix type error

* make auth-compat depend on app-compat

* add release build for auth-exp

* revert auth-compat to depend on app

* test

* don't abort on error for release builds

* apply release build to web worker build

* Revert "test"

This reverts commit 8be511c.

* fix lint error
@sam-gc
Finish off the emulator hooks (#3732)
37c1a01 
* Finish emulator implementation

* Formatting

* Add appVerificationDisabledForTesting setting and the type to auth-types-exp

* Formatting
@sam-gc
Add network timeout cancellation to the core network code (#3771)
2645dc9 
* Add network timeout cancellation to core network code

* Formatting

* Fix broken test on CI

* Formatting
@sam-gc
Fix failing auth compat tests (#3783)
0579912 
* Fix the auth compat 'tests'

* Formatting

* Fix integration test

* Formatting
@sam-gc
Add comment warning about indexed DB atomicity
7f275fd
@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2020

💥 No Changeset

Latest commit: 7f275fd

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (0579912) and head commit (ca59c3a).

Test Logs

@schmidt-sebastian
Copy link
Contributor

Approved for 7f275fd

@schmidt-sebastian schmidt-sebastian removed their assignment Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

@avolkovi avolkovi Awaiting requested review from avolkovi avolkovi is a code owner

@bojeil-google bojeil-google Awaiting requested review from bojeil-google

@scottcrossen scottcrossen Awaiting requested review from scottcrossen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sam-gc @google-oss-bot @schmidt-sebastian @avolkovi @scottcrossen @Feiyang1