Skip to content

[Without interface workaround] Auth Web OTP Retrieval #7546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 44 commits into
base: WebOTP
Choose a base branch
from
Open

[Without interface workaround] Auth Web OTP Retrieval #7546

wants to merge 44 commits into from

Conversation

Evanition
Copy link
Contributor

@Evanition Evanition commented Aug 11, 2023 •
edited by AngelAngelXie
Loading

This branch contained all the changes related to webOTP Autofill.
Includes changes in

  • confirmWithWebOTP
  • overloaded verifyPhoneNumber/_verifyPhoneNumber
  • overloaded signInWithPhoneNumber
  • unit tests

Evanition and others added 30 commits July 25, 2023 18:30
@Evanition
Implementing ConfirmWithWebOTP Method
2ed35fe
@Evanition
Update API reports
060c42a
@AngelAngelXie
changed firebase error to custom error messages
bfbc747
@AngelAngelXie
Update API reports
3508d6e
@Evanition
Implementing verifyPhoneNumber method
2f3416c
@Evanition
Update API reports
dc6df46
@AngelAngelXie
added overloaded signInWithPhoneNumber
b6af0af
@Evanition
overloading verifyPhoneNumber
73185ec
@Evanition
Update API reports
58fdc57
@Evanition
adding changes to demo app
bc82fe5
@Evanition
adding webOTPError Type
7004408
@AngelAngelXie
added unit tests & fixed documentations
a24db79
@AngelAngelXie
Update API reports
341dd90
@AngelAngelXie
formatted code
456fa58
@AngelAngelXie
removed unnecessary imports
00ee945
@AngelAngelXie
fixed demo app & modified errors
137e657
@AngelAngelXie
added documentation & fixed the fallback code
41eec76
@AngelAngelXie
fixed error message
89420d6
@AngelAngelXie
Revert "added unit tests & fixed documentations"
7d954a5 
This reverts commit a24db79.
@AngelAngelXie
attempt to fix totp integration test errors
b9de8ab
@AngelAngelXie
attempt to fix totp integration test
520ac96
@AngelAngelXie
editted demo app for web otp fallback handling
29abe5c
@AngelAngelXie
fixing errors
99fc534
@AngelAngelXie
clean up existing code
18bf34f
@AngelAngelXie
added unit tests for signInWithPhoneNumber
ca40b4b
@AngelAngelXie
attempt to resolve error
4a9196d
@AngelAngelXie
removed test changes
0d69efa
@AngelAngelXie
modifying rollup to resolve sourcemap warning
3845e1e
@AngelAngelXie
changed webOTPTimeoutname
1e8e2c8
@AngelAngelXie
cleaning up code
cec3a97
@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2023

⚠️ No Changeset found

Latest commit: 93a5edc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AngelAngelXie AngelAngelXie changed the base branch from master to WebOTP August 11, 2023 18:31
@AngelAngelXie AngelAngelXie changed the title DewayneTest5 [Without interface workaround] Auth Web OTP Retrieval Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egilmorez egilmorez Awaiting requested review from egilmorez egilmorez is a code owner

@markarndt markarndt Awaiting requested review from markarndt markarndt is a code owner

@kevinthecheung kevinthecheung Awaiting requested review from kevinthecheung kevinthecheung is a code owner

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@prameshj prameshj Awaiting requested review from prameshj prameshj is a code owner

@renkelvin renkelvin Awaiting requested review from renkelvin

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@dwyfrequency dwyfrequency Awaiting requested review from dwyfrequency

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evanition @AngelAngelXie