Skip to content

feat: Add support for new Firestore types #8994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: Add support for new Firestore types #8994

wants to merge 11 commits into from

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented May 2, 2025 •
edited
Loading

Adds support for MinKey, MaxKey, RegexValue, Int32Value, Decimal128Value, BsonObjectId, BsonTimestamp, and BsonBinaryData.

@ehsannas ehsannas requested review from a team as code owners May 2, 2025 21:55
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 2, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 60fd076

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@firebase/firestore Minor
firebase Patch
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ehsannas ehsannas requested a review from a team as a code owner May 2, 2025 22:07
@ehsannas
Copy link
Contributor Author

ehsannas commented May 2, 2025

@milaGGL please take a look, sanity check the PR, and handle the remaining TODOs where possible.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025

Changeset File Check ⚠️

  • Package @firebase/firestore has a minor bump which requires an additional line to bump the main "firebase" package to minor.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 5, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (3d44792)Merge (3437410)Diff
    browser395 kB418 kB+22.7 kB (+5.8%)
    main616 kB648 kB+32.3 kB (+5.2%)
    module395 kB418 kB+22.7 kB (+5.8%)
    react-native395 kB418 kB+22.7 kB (+5.8%)

  • @firebase/firestore-lite

    TypeBase (3d44792)Merge (3437410)Diff
    browser117 kB138 kB+21.8 kB (+18.7%)
    main160 kB190 kB+29.7 kB (+18.6%)
    module117 kB138 kB+21.8 kB (+18.7%)
    react-native117 kB139 kB+21.8 kB (+18.7%)

  • bundle

    15 size changes

    TypeBase (3d44792)Merge (3437410)Diff
    firestore (CSI Auto Indexing Disable and Delete)291 kB306 kB+14.9 kB (+5.1%)
    firestore (CSI Auto Indexing Enable)291 kB306 kB+14.9 kB (+5.1%)
    firestore (Persistence)322 kB337 kB+15.2 kB (+4.7%)
    firestore (Query Cursors)260 kB278 kB+17.7 kB (+6.8%)
    firestore (Query)258 kB276 kB+17.6 kB (+6.8%)
    firestore (Read data once)248 kB264 kB+16.3 kB (+6.6%)
    firestore (Read Write w Persistence)342 kB361 kB+19.1 kB (+5.6%)
    firestore (Realtime updates)248 kB264 kB+16.2 kB (+6.5%)
    firestore (Transaction)227 kB244 kB+17.0 kB (+7.5%)
    firestore (Write data)228 kB244 kB+15.9 kB (+7.0%)
    firestore-lite (Query Cursors)111 kB129 kB+17.6 kB (+15.8%)
    firestore-lite (Query)107 kB125 kB+17.6 kB (+16.4%)
    firestore-lite (Read data once)82.9 kB99.4 kB+16.5 kB (+19.9%)
    firestore-lite (Transaction)108 kB126 kB+17.6 kB (+16.3%)
    firestore-lite (Write data)92.4 kB109 kB+16.3 kB (+17.6%)

  • firebase

    TypeBase (3d44792)Merge (3437410)Diff
    firebase-compat.js807 kB826 kB+18.7 kB (+2.3%)
    firebase-firestore-compat.js351 kB370 kB+18.7 kB (+5.3%)
    firebase-firestore-lite.js140 kB165 kB+25.5 kB (+18.2%)
    firebase-firestore.js459 kB487 kB+28.0 kB (+6.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nrj9lMmpRd.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 5, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (1,441,594 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ny6ELwgBtv.html

milaGGL and others added 3 commits June 27, 2025 15:34
@milaGGL @ehsannas
Add decimal128 to new types (#344)
b640454 
* add decimal128

* add new tests

* format

* resolve comments

* update comments

* refactor compareNumbers

* copy paste Quadruple code

* resolve comments 1

* make Quadruple value in decimal128 private
@ehsannas
Merge remote-tracking branch 'origin-public/main' into mila/new-types
38faba5
@ehsannas
Fix merge conflicts.
60fd076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@milaGGL milaGGL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ehsannas @google-oss-bot @milaGGL