Escape variables in image entrypoints #1573
Merged
+36
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meallia
force-pushed
the
dont-substitute-variables-in-entrypoint
branch
from
d477934 to
ab3cdbe
Compare
|
while doing some more testing, I realized all entrypoint arguments are not properly escaped. putting this back to draft for now. |
Meallia
force-pushed
the
dont-substitute-variables-in-entrypoint
branch
from
ab3cdbe to
8bbb25b
Compare
Signed-off-by: Jonathan GAYVALLET <jonathan.mael.gayvallet@gmail.com>
Meallia
force-pushed
the
dont-substitute-variables-in-entrypoint
branch
from
8bbb25b to
14b47df
Compare
ANGkeith
approved these changes
May 24, 2025
|
nice, lgtm |
|
@Meallia is this ready? |
|
Yes, it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1572
During the creation of the docker command to execute the job, the entrypoint arguments were passed to bash surrounded by double quotes.
Bash would then substitute variables (like
${FOO}or$BAR), commands (like$(cmd)and`cmd`) in the context of the gitlab-ci-local process.By surrounding those arguments with single quotes and escaping them in the strings, bash won't try to do anything fancy with the strings and leave them as-is.