-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat/ export methods for echo cancellation #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
nader-nagy
wants to merge
884
commits into
flutter-webrtc:main
from
nader-nagy:feat/echo-cancellation-settings
Closed
feat/ export methods for echo cancellation #1149
nader-nagy
wants to merge
884
commits into
flutter-webrtc:main
from
nader-nagy:feat/echo-cancellation-settings
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change getLocalDescription,getRemoteDescription,RTCRtpSenderWeb.track returns to nullable. - Fixed bug in RTCPeerConnectionWeb.removeTrack. - Change MediaStreamTrack.captureFrame returns to ByteBuffer to compatible with web API. - Do null safety check in onRemoveStream,onRemoveTrack and MediaStream.getTrackById. - Add reStartCamera method when the camera is preempted by other apps. - Refactored RTCVideoRendererWeb and RTCVideoViewWeb, using video and audio HTML tags to render audio and video streams separately.
* Do not call reStartCamera() for screen capture * Add configuration "cryptoOptions" in parseRTCConfiguration()
…ebrtc#562) Co-authored-by: Ayman-Barghout <ayman.a.barghout@gmail.com>
…utter-webrtc#565 (flutter-webrtc#566) Co-authored-by: Ayman-Barghout <ayman.a.barghout@gmail.com>
…tc#580 (flutter-webrtc#581) Co-authored-by: Ayman-Barghout <ayman.a.barghout@gmail.com>
When application exits, it throws an exception: Exception 'java.lang.NullPointerException' occurred in thread 'main' at com.cloudwebrtc.webrtc.FlutterWebRTCPlugin.onDetachedFromActivity(FlutterWebRTCPlugin.java:97) See also issue flutter-webrtc#578 Signed-off-by: Peter Antoniac <pan1nx+flutterwebrtc@gmail.com>
Benefit from `dart_webrtc` latest fixes
* update. * chore: add getStatsByTrack. * update. * for darwin.
* Set the specified MediaStream trackId * 回退代码并添加web端设置trackId Co-authored-by: 佟博研 <tongby@haoxin.cn>
…brtc#1123) * fix: If have same remote streams id then found wrong MediaStream. * Default param * Specified peerconnection id. Co-authored-by: yuchang.xu <yuchang.xu@idreamsky.com>
* fix audio route/setSpeakerphoneOn issues. * Deactive rtc audio session when all local streams or peerconnections are closed. * Update common/darwin/Classes/FlutterWebRTCPlugin.h Co-authored-by: David Zhao <david@davidzhao.com> * Update common/darwin/Classes/AudioUtils.h Co-authored-by: David Zhao <david@davidzhao.com> * fix typo. * Add localTracks where it makes more sense. * update. Co-authored-by: David Zhao <david@davidzhao.com>
…webrtc#1108) (flutter-webrtc#1130) Co-authored-by: tatanka987 <tatanka.tvv@gmail.com>
Make this usable in Python3. MacOS removed Python2
Changes - Now there is a timeslice argument in startWeb Function of MediaRecorder, which also resolves the problem of onDataChunk Method not triggering unless we stop the recording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose echo cancellation settings to use from the method channel, this will help improve call quality and set the echo cancellation wherever we want.