Skip to content

improve submodule worktree changes #8798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Byron
Copy link
Collaborator

@Byron Byron commented May 28, 2025

Fixes #8792.

Tasks

  • do show ignored submodules by forcing our configuration override.
  • assure uncommittable changes aren't shown if submodule configuration is set to ignore = none.

Sorry, something went wrong.

Copy link

vercel bot commented May 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2025 9:39am

Copy link

vercel bot commented May 28, 2025

@Byron is attempting to deploy a commit to the GitButler Team on Vercel.

A member of the Team first needs to authorize it.

Verified

This commit was signed with the committer’s verified signature.
Byron Sebastian Thiel
Otherwise we might un-ignore ignored submodules.
But keep the optimization alive, after all we don't benefit from
doing thorough checks.

Finally, also make sure we don't show uncommittable submodule changes.
@Byron Byron force-pushed the submodule-changes-respect-configuration branch from 5ec9bb9 to 2ad6c15 Compare May 28, 2025 09:38
@Byron Byron marked this pull request as ready for review May 28, 2025 09:38
@Byron Byron enabled auto-merge May 28, 2025 09:38
@Byron Byron merged commit 1885203 into gitbutlerapp:master May 28, 2025
19 of 20 checks passed
@Byron Byron deleted the submodule-changes-respect-configuration branch May 28, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git submodule setting ignore = all should be followed
1 participant