Skip to content

ubuntu noble 24.04 fails due to regex #4245

Closed
@bdellegrazie

Description

@bdellegrazie
Contributor

Hi,

When testing with Ubuntu 24.04 the nodes fail to install the runner due to the following line:
https://github.com/philips-labs/terraform-aws-github-runner/blob/52ce9c15f68849c2aaf34e2bdec4b6f913d2c06d/modules/runners/templates/install-runner.sh#L45

Specifically, the condition:

os_id=$(awk -F= '/^ID/{print $2}' /etc/os-release)

On Ubuntu 24.04, the source file (/etc/os-release) looks something like:

ID=ubuntu
ID_LIKE=debian

which results in os_id having a value of:

ubuntu
debian

The correct expression is simply:

os_id=$(awk -F= '/^ID=/{print $2}' /etc/os-release)

I'll raise a PR.

Activity

elemenophy

elemenophy commented on Nov 11, 2024

@elemenophy

Related to #4178

added 5 commits that reference this issue on Nov 13, 2024
42f9848
5cb7209
github-actions

github-actions commented on Feb 10, 2025

@github-actions
Contributor

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

added a commit that references this issue on Feb 11, 2025
b807fbf
added a commit that references this issue on Mar 14, 2025
5c1a9e7
added a commit that references this issue on May 22, 2025
9d0041f
added a commit that references this issue on Jun 22, 2025
944ffcd
added a commit that references this issue on Jul 1, 2025
76456b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @bdellegrazie@elemenophy

      Issue actions

        ubuntu noble 24.04 fails due to regex · Issue #4245 · github-aws-runners/terraform-aws-github-runner