ubuntu noble 24.04 fails due to regex #4245
Description
Hi,
When testing with Ubuntu 24.04 the nodes fail to install the runner due to the following line:
https://github.com/philips-labs/terraform-aws-github-runner/blob/52ce9c15f68849c2aaf34e2bdec4b6f913d2c06d/modules/runners/templates/install-runner.sh#L45
Specifically, the condition:
os_id=$(awk -F= '/^ID/{print $2}' /etc/os-release)
On Ubuntu 24.04, the source file (/etc/os-release) looks something like:
ID=ubuntu
ID_LIKE=debian
which results in os_id having a value of:
ubuntu
debian
The correct expression is simply:
os_id=$(awk -F= '/^ID=/{print $2}' /etc/os-release)
I'll raise a PR.
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Participants
Activity
elemenophy commentedon Nov 11, 2024
Related to #4178
fix(runner-install): correct detection of Ubuntu 24.04
fix(runner-install): correct detection of Ubuntu 24.04
github-actions commentedon Feb 10, 2025
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.
fix(runner-install): correct detection of Ubuntu 24.04
fix(runner-install): correct detection of Ubuntu 24.04
fix(runner-install): correct detection of Ubuntu 24.04
fix(runner-install): correct detection of Ubuntu 24.04
feat(runner): support Ubuntu 24.04 (#4246)