-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Improve data flow in the async
package
#19770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Also, let me know if there's a way to avoid having two |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the contribution! I just have a few minor comments while waiting for evaluation results.
*/ | ||
DataFlow::SourceNode memberVariant(string name) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a publicly accessible predicate, we should avoid changing its signature. Instead, deprecate the original predicate and give a different name to the new predicate.
This predicate probably shouldn't have been public in the first place. Feel free to make the new one private.
succ = final.getParameter(1) and | ||
call.getName() = "sortBy" | ||
) | ||
class IterationPreserveTaintStepFlowSummary extends DataFlow::SummarizedCallable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class IterationPreserveTaintStepFlowSummary extends DataFlow::SummarizedCallable { | |
private class IterationPreserveTaintStepFlowSummary extends DataFlow::SummarizedCallable { |
You can merge the two classes by adding a field to the class, and embedding the value of the field in its |
Thanks, I'll make sure to fix the discrepancy. |
This PR makes these changes:
FlowSummaryPrivate.qll
: Added support foranyProperty
content set in flow summaries:async_.map({a: source()}, call_sink)
case. Let me know if there's a better way to do itElement
, which, according to the documentation, should select "an element of an array, iterator, or set object."AsyncPackage.qll
: Improve taint tracking through functions from theasync
package: