JS: Remove legacy actions queries #19849
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superseded by actions/untrusted-checkout/{medium,high,critical}
Superseded by actions/secrets-in-artifacts
Superseded by actions/command-injection/{medium,critical}
|
QHelp previews: |
There was a problem hiding this comment.
Pull Request Overview
This PR removes three legacy JavaScript QL queries (and their associated tests and references) that have been superseded by newer queries in the Actions QLPack, and adds change-notes plus a deprecation comment.
- Remove tests and reference entries for
ActionsArtifactLeak.ql - Remove tests and reference entries for
ExpressionInjection.ql - Remove tests and reference entries for
UntrustedCheckout.ql - Add deprecation note to
Actions.qlland update integration test suites - Add a change-note documenting the removal
Reviewed Changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| javascript/ql/test/query-tests/Security/CWE-312/ActionsArtifactLeak.* | Removed legacy test reference and expected output for the deprecated artifact-leak query |
| javascript/ql/test/query-tests/Security/CWE-094/ExpressionInjection/** | Removed composite and workflow tests for the deprecated command-injection query |
| javascript/ql/test/experimental/Security/CWE-094/** | Removed experimental tests for the deprecated pull-request-target query |
| javascript/ql/src/experimental/Security/CWE-094/UntrustedCheckout.* | Deleted deprecated pull-request-target query, examples, and docs |
| javascript/ql/src/Security/CWE-312/ActionsArtifactLeak.* | Deleted deprecated actions-artifact-leak query and docs |
| javascript/ql/src/Security/CWE-094/ExpressionInjection.* | Deleted deprecated command-injection query and docs |
| javascript/ql/lib/semmle/javascript/Actions.qll | Added pending deprecation comment |
| javascript/ql/src/change-notes/2025-06-23-remove-legacy-actions-queries.md | Added note documenting removal of legacy queries |
| javascript/ql/integration-tests/query-suite/*.expected | Updated integration test suites to remove references to deprecated queries |
javascript/ql/src/change-notes/2025-06-23-remove-legacy-actions-queries.md
Outdated
Show resolved
Hide resolved
…s-queries.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Napalys
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes three queries from the JS qlpack, which have been superseded by newer queries that are part of the Actions qlpack:
js/actions/pull-request-targethas been superseded byactions/untrusted-checkout/{medium,high,critical}js/actions/actions-artifact-leakhas been supersded byactions/secrets-in-artifactsjs/actions/command-injectionhas been superseded byactions/command-injection/{medium,critical}