Add Tencent SongGeneration library and enable download tracking #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhayna-zh
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c,
pcuenca and
ngxson
as code owners
|
The code looks great. Thanks! Let's wait for one of the owners to approve :) |
xianbaoqian
approved these changes
Jun 19, 2025
Vaibhavs10
reviewed
Jun 20, 2025
julien-c
approved these changes
Jun 20, 2025
|
The download counts should be live in a day or two @juhayna-zh 🤗 |
Wauplin
reviewed
Jun 25, 2025
| repoName: "songgeneration", | ||
| repoUrl: "https://github.com/tencent-ailab/songgeneration", | ||
| filter: false, | ||
| countDownloads: `path:"ckpt/songgeneration_base_zh/model.pt"`, |
There was a problem hiding this comment.
I think there is a typo in the path. The rule must be updated if we want to count download using https://huggingface.co/tencent/SongGeneration/blob/main/ckpt/songgeneration_base/model.pt
Suggested change
| countDownloads: `path:"ckpt/songgeneration_base_zh/model.pt"`, | |
| countDownloads: `path:"ckpt/songgeneration_base/model.pt"`, |
I opened #1554 to fix it
Wauplin
added a commit
that referenced
this pull request
Jun 25, 2025
Follow-up PR after #1542 cc @juhayna-zh @xianbaoqian @Vaibhavs10 There seems to be a typo in the download count rule. Checkpoint is saved at https://huggingface.co/tencent/SongGeneration/blob/main/ckpt/songgeneration_base/model.pt (under `songgeneration_base`, not `songgeneration_base_zh`). This PR fixes this. (I also took the opportunity to update `repoName`, it's usually best if it's the same as `prettyLabel`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures downloads tracking for https://huggingface.co/tencent/SongGeneration