Skip to content

Migrate to V2 Pydantic interface #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emmanuel-ferdman
Copy link
Contributor

What does this PR do?

This PR updates Pydantic V1 Model.schema() calls to the Pydantic V2 equivalent Model.model_json_schema() to resolve PydanticDeprecatedSince20 warnings.

Changes Made:

  • Replaced Animals.schema() with Animals.model_json_schema() in docs/source/basic_tutorials/using_guidance.md.
  • Replaced multiple instances of Weather.schema() with Weather.model_json_schema() in integration-tests/models/test_grammar_response_format_llama.py.

These changes ensure compatibility with Pydantic V2+ and address deprecation warnings related to the Model.schema() method, as observed in CI logs.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@emmanuel-ferdman
Copy link
Contributor Author

@regisss @Narsil could you please review this small PR when you get the chance? thank you 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant