[SYCL][NativeCPU] Add libclc at compile time. #19346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches what is done for CUDA and HIP.
|
cc @intel/llvm-reviewers-cuda, comments welcome on that TODO comment for CUDA. |
npmiller
reviewed
Jul 8, 2025
| if (TC->getTriple().isNVPTX() || isNativeCPU) { | ||
| // For NVPTX we need to also link libclc at the same stage that we link | ||
| // all of the unbundled SYCL libdevice objects together. | ||
| // TODO: libspirv should have been linked in already by |
There was a problem hiding this comment.
There was a problem hiding this comment.
Ah, thanks, that makes sense. In that case, I will tweak the comment accordingly but not make any functional changes for CUDA. For Native CPU, we don't link in those other libdevice files anyway so we are not affected by that.
There was a problem hiding this comment.
That's right, at least for CUDA/HIP the main offenders seem to be the iteration space functions, see: https://github.com/intel/llvm/blob/sycl/libdevice/spirv_vars.h#L17
srividya-sundaram
approved these changes
Jul 8, 2025
uwedolinsky
approved these changes
Jul 9, 2025
|
@intel/llvm-gatekeepers This can be merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches what is done for CUDA and HIP.