Skip to content

feat: Added location heading field #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joaoGabriel55
Copy link
Contributor

Fixed issue #158

@joaoGabriel55
Copy link
Contributor Author

Two questions @vjgarciag96:

  • I could not found InlineQueryResultLocation and InputLocationMessageContent files/classes. Do they still exist?
  • How can I create test suites for sendLocation and editMessageLiveLocation API client methods?

Copy link
Member

@vjgarciag96 vjgarciag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

Re. your questions:

Comment on lines +7 to +18
@Test
fun `should permit to not inform heading optional attribute value`() {
val location = Location(23.4F, 45.0F)
Assertions.assertEquals(location.heading, null)
}

@Test
fun `should permit to inform heading optional attribute value`() {
val locationHeading = 34
val location = Location(23.4F, 45.0F, locationHeading)
Assertions.assertEquals(location.heading, locationHeading)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change, but it feels like we don't need this test - it's mainly testing a Kotlin language feature rather than actual logic of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants