added cycle state to pick & process results in profile handler #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nirrozenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
fyi @kfirtoledo |
|
/lgtm |
k8s-ci-robot
added
lgtm
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
nirrozenbaum
force-pushed
the
cycle-state
branch
from
378e220 to
c7b3c1b
Compare
k8s-ci-robot
removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
shmuelk
pushed a commit
to shmuelk/gateway-api-inference-extension
that referenced
this pull request
Jun 24, 2025
…netes-sigs#1040) * added cycle state to pick + process results of profile handler Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * wildcard Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
rlakhtakia
pushed a commit
to rlakhtakia/gateway-api-inference-extension
that referenced
this pull request
Jun 26, 2025
…netes-sigs#1040) * added cycle state to pick + process results of profile handler Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * wildcard Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
rlakhtakia
pushed a commit
to rlakhtakia/gateway-api-inference-extension
that referenced
this pull request
Jun 26, 2025
…netes-sigs#1040) * added cycle state to pick + process results of profile handler Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * wildcard Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
EyalPazz
pushed a commit
to EyalPazz/gateway-api-inference-extension
that referenced
this pull request
Jul 9, 2025
…netes-sigs#1040) * added cycle state to pick + process results of profile handler Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * wildcard Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CycleState arg to
PickandProcessResultsfunctions ofProfileHandler.Additional minor change is being consistent in arguments order across all scheduling plugins.
after this PR all plugins receive first args (context, cycle-state) and then the plugin specific args like request, etc.
This was raised by @kfirtoledo while working on PD scorer, and had the requirement to access some of the scorer calculations in ProcessResults (need to communicate it through CycleState).
NO LOGIC CHANGE.