Skip to content

Lint: core.Endpoints is deprecated: Use discoveryv1.EndpointSlice. (staticcheck) #20677

Closed
@medyagh

Description

@medyagh

in our service_test.go we need to use the new api for endpoints

Error: pkg/minikube/service/service_test.go:192:39: SA1019: core.Endpoints is deprecated: This API is deprecated in v1.33+. Use discoveryv1.EndpointSlice. (staticcheck)
	*gentype.FakeClientWithListAndApply[*core.Endpoints, *core.EndpointsList, *corev1.EndpointsApplyConfiguration]
	                                     ^
Error: pkg/minikube/service/service_test.go:194:13: SA1019: core.Endpoints is deprecated: This API is deprecated in v1.33+. Use discoveryv1.EndpointSlice. (staticcheck)
	Endpoints *core.Endpoints
	           ^
Error: pkg/minikube/service/service_test.go:197:31: SA1019: core.Endpoints is deprecated: This API is deprecated in v1.33+. Use discoveryv1.EndpointSlice. (staticcheck)
var endpointMap = map[string]*core.Endpoints{
                              ^
Error: pkg/minikube/service/service_test.go:200:[14](https://github.com/kubernetes/minikube/actions/runs/14716124735/job/41299785095?pr=20673#step:6:15): SA1019: core.EndpointSubset is deprecated: This API is deprecated in v1.33+. (staticcheck)
		Subsets: []core.EndpointSubset{
		           ^
Error: pkg/minikube/service/service_test.go:211:14: SA1019: core.EndpointSubset is deprecated: This API is deprecated in v1.33+. (staticcheck)
		Subsets: []core.EndpointSubset{
		           ^
Error: pkg/minikube/service/service_test.go:223:14: SA10[19](https://github.com/kubernetes/minikube/actions/runs/14716124735/job/41299785095?pr=20673#step:6:20): core.EndpointSubset is deprecated: This API is deprecated in v1.33+. (staticcheck)
		Subsets: []core.EndpointSubset{
		           ^
make[1]: *** [Makefile:537: lint-ci] Error 1
``
https://github.com/kubernetes/minikube/actions/runs/14716124735/job/41299785095?pr=20673

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions