Skip to content

Fixed the issue where the service could not change from Loadbalancer to ClusterIP/NodePort #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2025
Merged

Fixed the issue where the service could not change from Loadbalancer to ClusterIP/NodePort #2729

merged 1 commit into from
Aug 15, 2025
+200 −3

Conversation

Lanyujiex
Copy link

@Lanyujiex Lanyujiex commented Apr 30, 2025 •
edited
Loading

Fixed the issue where the service could not change from Loadbalancer to ClusterIP/NodePort

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
/kind test

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #2728

Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...

What else do we need to know?

@Lanyujiex Lanyujiex requested a review from a team as a code owner April 30, 2025 08:08
@netlify Netlify
Copy link

netlify bot commented Apr 30, 2025 •
edited
Loading

✅ Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 058375e
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/6811da957bf3570008ba0428

@Lanyujiex Lanyujiex changed the title Fixed the issue where the service could not change from Loadbalancer … Fixed the issue where the service could not change from Loadbalancer to ClusterIP/NodePort Apr 30, 2025
@Lanyujiex Lanyujiex force-pushed the ebcloud-dev branch 3 times, most recently from 29a925a to f9ab0af Compare May 13, 2025 07:28
zerbitx
zerbitx approved these changes Jul 7, 2025 •
edited
Loading
View reviewed changes
@zerbitx zerbitx self-requested a review July 7, 2025 16:13
zerbitx
zerbitx requested changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@zerbitx zerbitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you test this as well here?

Also, with changing the virtual object's spec and status after its assigned from the host status, do these changes make it back to the host object eventually. I haven't had a moment to test this out for myself.

@Lanyujiex Lanyujiex requested a review from FabianKramm as a code owner July 12, 2025 12:22
@Lanyujiex Lanyujiex requested a review from zerbitx July 14, 2025 13:41
zerbitx
zerbitx approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@zerbitx zerbitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for those tests! I just got a chance to test it out and looks good.

zerbitx
zerbitx requested changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@zerbitx zerbitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I spoke too soon, and there are failing tests. See: https://github.com/loft-sh/vcluster/actions/runs/16260609788/job/45935421118?pr=2729

Fixed the issue where the service could not change from Loadbalancer …
Loading
Loading status checks…
cee9a0e 
…to ClusterIP/NodePort

Signed-off-by: yujiel <yujiel@ebtech.com>
@Lanyujiex
Copy link
Author

Looks like I spoke too soon, and there are failing tests. See: https://github.com/loft-sh/vcluster/actions/runs/16260609788/job/45935421118?pr=2729
Sorry about that — I’ve addressed the related errors and pushed the fixes. Please take another look when you have time.

@Lanyujiex Lanyujiex requested a review from zerbitx July 15, 2025 05:55
@zerbitx zerbitx merged commit 7d2bcf1 into loft-sh:main Aug 15, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zerbitx zerbitx

@FabianKramm FabianKramm

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Service type change from LoadBalancer to ClusterIP is not reflected in host cluster

2 participants

@Lanyujiex @zerbitx