Skip to content

request_id missing on types GetPageResponse, QueryDatabaseResponse and GetDatabaseResponse #505

Open
@borisghidaglia

Description

@borisghidaglia

Describe the bug
request_id missing on types GetPageResponse, QueryDatabaseResponse and GetDatabaseResponse

Indeed, it is included in the response but does not appear in types.
Similar to #487

To Reproduce
Node version: v21.7.3
Notion JS library version: 2.2.15

Steps to reproduce the behavior:

  • retrieve a db using client.pages.retrieve, client.databases.retrieve or client.databases.query and save this data as a TS const somewhere.
  • add the satisfies operator like and replace X with the appropriate type.
const notionData = {...} satisfies X; 

You will get this error (as an example with GetPageResponse):
Object literal may only specify known properties, and 'request_id' does not exist in type 'GetPageResponse'

Expected behavior
satisfies X on the data should work as the functions mentioned above return a Promise<X>.

Activity

linked a pull request that will close this issue on May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @borisghidaglia

      Issue actions

        `request_id` missing on types `GetPageResponse`, `QueryDatabaseResponse` and `GetDatabaseResponse` · Issue #505 · makenotion/notion-sdk-js