Skip to content

[Fix] embed relations serialization #3410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 5.x
Choose a base branch
from

Conversation

florianJacques
Copy link
Contributor

Checklist

  • Add tests and ensure they pass

@florianJacques florianJacques requested a review from a team as a code owner June 17, 2025 09:03
@florianJacques
Copy link
Contributor Author

Hello,
Why Coding Standards / phpcs (pull_request)
Fail ?

@GromNaN
Copy link
Member

GromNaN commented Jun 17, 2025

In order to review the PR properly, could you add some tests that are fixed by the change?

Why Coding Standards / phpcs (pull_request) Fail?

GitHub Action fails to commit the fixes that are found by phpcs.

----------------------------------------------------------------------
FILE                                                  FIXED  REMAINING
----------------------------------------------------------------------
src/Eloquent/EmbedsRelations.php                      2      0
src/Eloquent/DocumentModel.php                        1      0
----------------------------------------------------------------------
A TOTAL OF 3 ERRORS WERE FIXED IN 2 FILES
----------------------------------------------------------------------

@florianJacques
Copy link
Contributor Author

Yes of course, I will write the tests in the next few days
For CI errors, can I do something?

@GromNaN
Copy link
Member

GromNaN commented Jun 17, 2025

For CI errors, can I do something?

You can run vendor/bin/phpcbf locally to fix the CS issues.

@florianJacques
Copy link
Contributor Author

Thanks, Done! I'll write the tests when I have some time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants