Skip to content

fix(dashboard): use more idiomatic react-querybuilder code #8059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 8, 2025

Conversation

jakeboone02
Copy link
Contributor

@jakeboone02 jakeboone02 commented Apr 3, 2025

What changed? Why was the change needed?

The prepareRuleGroup function is not necessary to add ids to query objects generated from parseJsonLogic since v8.3.0 of react-querybuilder. This PR removes unnecessary prepareRuleGroup calls, updates the RQB dependency to v8.4.1, and moves an inline function prop to a stable reference to help with memoization.

I don't know how this project manages dependency updates, so maybe you can't merge this directly but if nothing else it can provide a couple of usage tips.

Screenshots

N/A

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

I'm the maintainer of react-querybuilder and I just noticed this project. It's cool to see RQB being used so effectively! If you folks have any questions or feedback for me, please reach out!

EDIT: One more thing—the "here" link on this line is dead (gets a 404):

To learn more about the project structure and running the project locally, please have a look [here](https://docs.novu.co/community-support/introduction#run-novu-locally?utm_campaign=github-contrib).

Copy link

netlify bot commented Apr 3, 2025

Deploy preview added

Name Link
🔨 Latest commit 6f7bc60
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/6845cbf1217716000852719b
😎 Deploy Preview https://deploy-preview-8059.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@scopsy scopsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jakeboone02 appreciate it a lot!

@scopsy scopsy merged commit a4d1a51 into novuhq:next Jun 8, 2025
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants