feat(root): create keyless environment #8276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g for keyless authentication
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@novu/js
@novu/nextjs
novu
@novu/react
@novu/react-native
@novu/providers
@novu/shared
commit: |
…hance rate limiting logic
…tion functionality in footer
…keyless mode in footer
…ntegrate with NotificationListSkeleton
…keyless environments
…ssion retention logic
scopsy
reviewed
May 15, 2025
apps/api/src/app/auth/services/passport/subscriber-jwt.strategy.ts
Outdated
Show resolved
Hide resolved
| applicationIdentifier: body.applicationIdentifier, | ||
| subscriberHash: body.subscriberHash, | ||
| origin, | ||
| }) | ||
| ); | ||
| } | ||
|
|
||
| private buildSubscriber(body: SubscriberSessionRequestDto): SubscriberDto { | ||
| if (!body.applicationIdentifier || body.applicationIdentifier.startsWith('pk_keyless_')) { | ||
| return { subscriberId: 'keyless-subscriber-id' }; |
There was a problem hiding this comment.
I wonder, why not let the Inbox generate some random one and persist it? So we don't need to modify this API part of it.
There was a problem hiding this comment.
good question. I was not sure who should be responsible for the subscriber generation. to me, it felt like we would want as little logic in the Inbox as possible, so I moved this logic to the API.
let me know what you think about it.
… HttpClient defaults, and simplify subscriber logic
…date StandardBaseProps structure
…remove unused decorators, and update avatar URLs
…d streamline subscriber handling
…bscriber logic, and improve keyless identifier management
… helper function for test environment
…nto create-keyless-environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
EE-PR
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer