Closed
Description
New Issue Checklist
- I am not disclosing a vulnerability.I am not just asking a question.I have searched through existing issues.I can reproduce the issue with the latest versions of Parse Server and the Parse .NET SDK.
Issue Description
Parse.ParseUser.LogOutAsync
test fails.
Activity
parse-github-assistant commentedon Dec 20, 2024
Thanks for opening this issue!
mtrezza commentedon Dec 20, 2024
@YBTopaz8 could you take a look this if you have some time? The CI is currently failing, which may be the issue one can see in your screenshot in #393 (comment). At the time I assumed that you fixed the failing test, because the CI passed in that PR, but it turned out that there was a bug in the CI that ignored failing tests. I've fixed the CI bug in #398, so the CI fails now properly. But of course we need to get the CI passing. From the CI point of view we don't know whether that is a test issue or a feature issue.
YBTopaz8 commentedon Dec 20, 2024
Appreciate the insight.
I'm fairly sure it's a test issues as logout works well trying to see from what angle I can fix the test.
Would you like for me to do several PRs as I fix issues moving forward, or would you prefer one PR to be done (before the LQ PR)
By the way for LQ, before release, we will need to do the documentation.
We would need to do the docs for all of .NET since it's still talking about XAMARIN.
If all the same to you, I can update the docs over the weekend - Just need to show me around.
mtrezza commentedon Dec 20, 2024
Yes, please one PR per issue; also see here.
Sure, the docs are in the docs repo. If you just go through the _includes directory you'll easily figure out the modular structure of the docs and where to edit.
YBTopaz8 commentedon Dec 20, 2024
Good News!
All tests pass even the LogOut and Link.
Bad News : Our coverage probably dropped (since I have now 189 tests instead of 200 as initially)
Another good news: I decided to learn UT so, I'll be adding more UT to improve coverage to be at least back to before v4.0 OR better covered.
Cheers.
mtrezza commentedon Dec 20, 2024
Could you please link your PR to this issue so we can review?
YBTopaz8 commentedon Dec 21, 2024
#402
mtrezza commentedon Dec 21, 2024
Could you please open a separate PR just for this issue, without including any other changes? Please see here why. I assume it should be a relatively small PR.
Bug Fix.
Parse.ParseUser.LogOutAsync
optimization #403parseplatformorg commentedon Dec 24, 2024
🎉 This change has been released in version 4.0.1