Skip to content

if no deviceToken, count is never decremented fully, and the PushStatus never marked success/fail #54

Open
@jeacott1

Description

@jeacott1

if I have no deviceToken assigned, and send a push to that Installation,
then in PushAdapterUtils.classifyInstallations:

// No deviceToken, ignore
if (!installation.deviceToken) {
continue;
}

completely shortcuts any attempted execution of push to these devices.

this is fine, but because the push is never sent, no response from the push service can decrement the count,
so it never completes, and PushStatus is left in a 'running' state with outstanding count equal to the number of null deviceToken records.

somewhere here, this needs to either drop the total count, or decrement the oustanding count,
or just drop the if/continue altogether.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions