-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix: set default Content Type header to "binary/octet-stream" #7603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request!
|
I think it should be a more pretty solution than add Content-Disposition header as I did in the prev PR #7571 |
I will reformat the title to use the proper commit message syntax. |
Codecov Report
@@ Coverage Diff @@
## master #7603 +/- ##
==========================================
+ Coverage 93.94% 93.97% +0.03%
==========================================
Files 181 181
Lines 13279 13354 +75
==========================================
+ Hits 12475 12550 +75
Misses 804 804
Continue to review full report at Codecov.
|
Did this ever get pushed to a live version? Seems to make sense. |
@santiagoprieto See #7572 |
New Pull Request Checklist
I can't download a file with ext
*.data
. The parse server returnContent-Type: null
I would to have a default type
Content-Type: binary/octet-stream
Issue Description
Related issue: #7572