Skip to content

fix: set default Content Type header to "binary/octet-stream" #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

igor-lemon
Copy link

New Pull Request Checklist

I can't download a file with ext *.data. The parse server return Content-Type: null
I would to have a default type Content-Type: binary/octet-stream

Issue Description

Related issue: #7572

  • Add test cases
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK
  • ...

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 2, 2021

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@igor-lemon igor-lemon changed the title Exp fix: Set default Content Type header to "binary/octet-stream" Oct 2, 2021
@igor-lemon
Copy link
Author

igor-lemon commented Oct 2, 2021

I think it should be a more pretty solution than add Content-Disposition header as I did in the prev PR #7571

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: Set default Content Type header to "binary/octet-stream" fix: set default Content Type header to "binary/octet-stream" Oct 24, 2021
@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #7603 (25d1dc5) into master (fdb7dfb) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7603      +/-   ##
==========================================
+ Coverage   93.94%   93.97%   +0.03%     
==========================================
  Files         181      181              
  Lines       13279    13354      +75     
==========================================
+ Hits        12475    12550      +75     
  Misses        804      804              
Impacted Files Coverage Δ
src/Routers/FilesRouter.js 88.54% <100.00%> (ø)
src/batch.js 91.37% <0.00%> (-1.73%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 79.50% <0.00%> (-0.82%) ⬇️
src/RestWrite.js 94.04% <0.00%> (-0.07%) ⬇️
src/Options/Definitions.js 100.00% <0.00%> (ø)
src/GraphQL/loaders/functionsMutations.js 100.00% <0.00%> (ø)
src/GraphQL/loaders/parseClassMutations.js 100.00% <0.00%> (ø)
src/cloud-code/Parse.Cloud.js 99.20% <0.00%> (+<0.01%) ⬆️
src/GraphQL/loaders/parseClassQueries.js 98.03% <0.00%> (+0.03%) ⬆️
src/Config.js 93.39% <0.00%> (+0.08%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb7dfb...25d1dc5. Read the comment docs.

@santiagoprieto
Copy link

Did this ever get pushed to a live version? Seems to make sense.

@mtrezza
Copy link
Member

mtrezza commented Sep 8, 2023

@santiagoprieto See #7572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants