-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: add Huawei auth adapter #7721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Conversation
Add huawei auth adapter I refer to google auth adapter
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## alpha #7721 +/- ##
==========================================
- Coverage 93.95% 93.79% -0.16%
==========================================
Files 183 184 +1
Lines 13660 13691 +31
==========================================
+ Hits 12834 12842 +8
- Misses 826 849 +23
Continue to review full report at Codecov.
|
1. Run eslint eslint src/Adapters/Auth/huawei.js --fix 2. Reformat error message 3. Add new line to last of page
- Add dot to end of message. - Remove ambiguos message "No SubError" - Change capitalization
Do we need any tests here? Do other auth adapters have specific tests? |
I only use Facebook and Huawei now. These two adapters are working well in common case.
And my service uses very limited APIs
I only tested upper cases. |
I mean whether there are existing automated tests for other auth adapters, that we also need to add for this new Huawei adapter? See the /spec folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the tests to cover the adapter? See TwitterAuth.spec.js
as an example.
Add huawei auth adapter
I refer to google auth adapter
More information about huawei oauth: Huawei developer
New Pull Request Checklist
Issue Description
Related issue: FILL_THIS_OUT
Approach
TODOs before merging