fix: handle undefined values in afterChange hooks when read:false and create:true on the field level access for parents and siblings #12664
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamacup
changed the title
iamacup
changed the title
GermanJablo
changed the title
GermanJablo
requested changes
Jul 8, 2025
There was a problem hiding this comment.
Thanks so much @iamacup. There are some integration tests related to your PR that are failing. Could you please review them?
You're almost there! Great work!
fix(tests): remove unneeded else statement
|
@GermanJablo some changes which have made it fail less, I think this is failing the UUID check in postgres but im not sure exactly why, can you help at all? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a bug where
afterChangehooks would attempt to access values for fields that areread: falsebutcreate: true, resulting inundefinedvalues and unexpected behavior.Why?
In scenarios where access control allows field creation (
create: true) but disallows reading it (read: false), hooks likeafterChangewould still attempt to operate onundefinedvalues fromsiblingDocorpreviousDoc, potentially causing errors or skipped logic.How?
Adds safe optional chaining and fallback object initialization in
promise.tsfor:previousDoc[field.name]siblingDoc[field.name]This ensures that these values are treated as empty objects or arrays where appropriate to prevent runtime errors during traversal or hook execution.
Fixes #12660