Skip to content

chore: bump golangci-lint to v2.0.2 #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Apr 25, 2025

Description

Bump golangci-lint to v2.0.2 (aligned with prometheus actual version) and fixes newly raised issues

@mmorel-35 mmorel-35 force-pushed the golangci-lint@v2 branch 5 times, most recently from 0371782 to 72b1455 Compare April 25, 2025 06:05
@mmorel-35 mmorel-35 marked this pull request as ready for review April 25, 2025 06:09
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Apr 25, 2025

/cc @kakkoyun @SuperQ

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@@ -138,7 +138,7 @@ func FallbackMatcherParser(l *slog.Logger) ParseMatcher {
}
// If the input is valid in both parsers, but produces different results,
// then there is disagreement.
if nErr == nil && cErr == nil && !reflect.DeepEqual(nMatcher, cMatcher) {
if cErr == nil && !reflect.DeepEqual(nMatcher, cMatcher) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the specific linter error here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this nErr is already nil here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants