feat(rocketchat): support plain text attribute #4393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add plainText attribute to set plain text message additionally to attachment. Signed-off-by: Patrick Remy <patrick-remy@users.noreply.github.com>
Patrick-Remy
force-pushed
the
feat/rocketchat-support-plaintext
branch
from
845c44c to
a31aeb5
Compare
|
Maybe @TheMeier as the original contributor for the rocketchat integration can review my contribution. |
|
I just tested it and then remembered, if you send a
on-top Text from the API call is not even displayed anywhere for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RocketChat doesn't set the attachment title as notification title. Instead with the current implementation of this notifier, you receive notifications like
"bot: ". This is really unuseful.The
PostMessage.Textattribute was already typed and can be additionally set to set a "plain text".I also fixed the previously 404 rocketchat developer documentation which has moved in the meantime and removed the unused (and undocumented) property
ParseUrls.