Skip to content

Replace(?) deprecated installation instructions in "Instrumenting a Go application for Prometheus" docs #2556

Open
@atimeofday

Description

@atimeofday

Hello,

As a new user of both Go and Prometheus, I ran into some issues and tentatively believe the instructions for installing the prometheus/client_golang libraries are outdated as of Go 1.17 in... August 2021. It appears go get was deprecated outside of Go Modules, and requires the creation of a Go Module first. Please let me know if this impression is incorrect, or if a small PR to adjust the instructions might be welcome.

Issue location: https://github.com/prometheus/docs/blob/main/content/docs/guides/go-application.md#installation
Issue contents:

go get github.com/prometheus/client_golang/prometheus
go get github.com/prometheus/client_golang/prometheus/promauto
go get github.com/prometheus/client_golang/prometheus/promhttp

Potential solution: preface go get instructions with go mod init <module_name> and a link to Go Module documentation

Activity

beorn7

beorn7 commented on Dec 17, 2024

@beorn7
Member

I guess you are right, these are outdated instruction to get Go packages. A PR fixing this would be very welcome.

lhajouji

lhajouji commented on Dec 20, 2024

@lhajouji
Contributor

Hello @beorn7,

I would gladly work on this.
Would you please assign it to me ?

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @beorn7@lhajouji@atimeofday

    Issue actions

      Replace(?) deprecated installation instructions in "Instrumenting a Go application for Prometheus" docs · Issue #2556 · prometheus/docs