Skip to content

proposal: PROM-<number> Proposal Referencing #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

proposal: PROM-<number> Proposal Referencing #53

merged 3 commits into from
May 23, 2025

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented May 9, 2025

Fixes #51

Signed-off-by: bwplotka <bwplotka@gmail.com>
Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This would make things much easier! :)

Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nits.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Copy link
Member

@machine424 machine424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Signed-off-by: bwplotka <bwplotka@gmail.com>
@bwplotka bwplotka merged commit 7d2aaf1 into main May 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add unique number ID for each proposal e.g. PROM-1234 or PP-123
6 participants