Skip to content

Improve crontab #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2024
Merged

Improve crontab #1193

merged 3 commits into from
Nov 17, 2024

Conversation

JakkuSakura
Copy link
Contributor

@JakkuSakura JakkuSakura commented Sep 1, 2024

This should be able to fix #1192, fix #1191, fix #1189

@JakkuSakura JakkuSakura marked this pull request as ready for review September 2, 2024 17:31
@JakkuSakura JakkuSakura marked this pull request as draft September 17, 2024 05:18
@JakkuSakura JakkuSakura marked this pull request as ready for review September 26, 2024 04:00
@simonhammes
Copy link
Contributor

@JakkuSakura Can you fix the linting issues? Running ./scripts/dev-lint.sh should be enough.

Make sure that you've activated the virtual environment in advance to ensure that the script uses the correct tool versions (and not some globally installed versions).

@JakkuSakura
Copy link
Contributor Author

Hi, I fixed the linting and squashed the commits.

Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this is awesome, thank you @JakkuSakura!

I suppose it's sort-of backwards compatible - by which I mean the use of the fact can be identical to before, but technically the types have changed in a non-compatible way. But resulting UX works and this is a significant improvement, I think that wins.

@Fizzadar Fizzadar merged commit 612c59f into pyinfra-dev:3.x Nov 17, 2024
22 checks passed
@Fizzadar Fizzadar mentioned this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants