-
Notifications
You must be signed in to change notification settings - Fork 2.6k
SentinelManagedConnection searches for new master upon connection failure (#3560) #3601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SentinelManagedConnection searches for new master upon connection failure (#3560) #3601
Conversation
Hi @ManelCoutinhoSensei, thank you for your contribution! We’ll review your change soon(after PR #3596 :) ). |
It's been 2 months... do you have any updates @petyaslavova ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ManelCoutinhoSensei,
Apologies for the late response. I’ve reviewed the code and added a few comments.
dc0556b
to
7e84758
Compare
@ManelCoutinhoSensei, please check why tests are failing. |
ed67cd1
to
1492c3a
Compare
Hi @petyaslavova , besides the one workflow that fails due to having the same name as another, all tests seem to pass here |
1492c3a
to
7af0b7f
Compare
Thank you so much, @petyaslavova. Once this is closed, I'll update the other PR accordingly |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixes #3560. It should be reviewed after merging #3596