Open
Description
Now that min_const_generics
is stabilized, I suspect it won't be long for array_windows
and array_chunks
to be stabilized as well. It would be nice to have a lint ready when that comes. But for now we can check the feature gates.
What it does
Checks for usage of windows
or chunks
with a constant size. These may be replaced with array_windows
and array_chunks
respectively.
Categories (optional)
- Kind: perf
What is the advantage of the recommended code over the original code
It avoids heap allocation and should be more performant. Also it often simplifies the code since you can destructure the array.
Drawbacks
None.
Example
for window in slice.windows(2) {
println!("{} {}", w[0], w[1]);
}
Could be written as:
for [a, b] in slice.array_windows() {
println!("{} {}", a, b);
}
Maybe we should avoid linting if the array would be too big?
Activity
pitaj commentedon Apr 2, 2022
How can the array be "too big"? Don't
array_windows
andarray_chunks
always return a reference into already-allocated memory?camsteffen commentedon Apr 2, 2022
"too big" because it's not practical to write out 100 array elements.
pitaj commentedon Apr 2, 2022
You could still use the array like you would a slice though, right?
camsteffen commentedon Apr 2, 2022
Yeah that's true.
mchodzikiewicz commentedon Mar 25, 2025
@rustbot claim
array_chunks_and_windows
Add initial impl of array_chunks_and_windows
Add initial impl of array_chunks_and_windows lint
Add initial impl of array_chunks_and_windows lint
6 remaining items