Skip to content

Assign changes of CHANGELOG.md to flip1995 #15131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samueltardieu
Copy link
Contributor

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2025

r? @flip1995

rustbot has assigned @flip1995.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 25, 2025
@y21
Copy link
Member

y21 commented Jun 25, 2025

This means only @flip1995 gets assigned changelog PRs from now on, right? Is there a reason for this? The past two were assigned to flip on request explicitly, but I think this has usually worked out fine with the usual reviewers as the assignee for changelogs?

@samueltardieu
Copy link
Contributor Author

samueltardieu commented Jun 26, 2025

Maybe, I was under the impression that @flip1995 wanted to have a say on user-facing documentation changes such as README or ChangeLog changes. This doesn't prevent us from merging non-controversial changes, as we do on PRs assigned to others when we want to take the lead, this is just a way to skew the random assignment to 100% @flip1995 by default.

I have no problem with @flip1995 closing this one if he doesn't want to be the preferred contact point for ChangeLog changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants