Skip to content

Fix search_is_some suggests wrongly inside macro #15135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2025
Merged

Fix search_is_some suggests wrongly inside macro #15135

merged 1 commit into from
Jul 29, 2025

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Jun 25, 2025 •
edited by rustbot
Loading

Closes #15102

changelog: [search_is_some] fix wrong suggestions inside macro

@rustbot
Copy link
Collaborator

rustbot commented Jun 25, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 25, 2025
@blyxyas
Copy link
Member

blyxyas commented Jul 11, 2025

Alexendoo's a little bit over the top on capacity (32 assigned PRs)
I'll shave off his last uncommented PRs.

r? @blyxyas

@rustbot rustbot assigned blyxyas and unassigned Alexendoo Jul 11, 2025
blyxyas
blyxyas requested changes Jul 13, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jul 13, 2025
@profetia
Copy link
Contributor Author

Updated. Thank you!

@profetia profetia requested a review from blyxyas July 14, 2025 14:39
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Jul 14, 2025
@profetia
Copy link
Contributor Author

Any feedback? @blyxyas

blyxyas
blyxyas approved these changes Jul 29, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️ 🌈 This bugfix is looking great.

@blyxyas blyxyas added this pull request to the merge queue Jul 29, 2025
Merged via the queue into rust-lang:master with commit b7cc5c4 Jul 29, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas

Assignees

@blyxyas blyxyas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search_is_some suggests broken code when match guard is present
4 participants
@profetia @rustbot @blyxyas @Alexendoo