-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyArea: Name/path resolution done by `rustc_resolve` specificallyA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
This is a similar story to #140765. Basically tests/ui/issues/issue-7663.rs doesn't test anything as the glob imports were removed from the file and there's no duplicated import for p
on either case.
I think the test should no longer be run-pass
and instead it should test that:
- Importing both
p
items with glob imports fails - Importing both
p
items with non-glob imports fails - Importing one
p
with a glob import and anotherp
with a non-glob import is ok.
I'll create a PR with a fix if this is correct.
Thanks!
Metadata
Metadata
Assignees
Labels
A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyArea: Name/path resolution done by `rustc_resolve` specificallyA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
jieyouxu commentedon May 14, 2025
Yes, that test is not checking what it was originally checking. Try to see if existing tests in
tests/ui/resolve/
covers those cases already.pvdrz commentedon May 15, 2025
The third case is covered by
tests/ui/resolve/hidden_glob_reexports.rs
but I couldn't find any test that covers the other two. I'm movingissue-7663.rs
totests/ui/resolve
and repurposing to test the first two cases.Fix test for rust-lang#7663