Closed
Description
Lines 270 to 271 in c38a5de
The comment is confusing. On Windows, the epoch is not 01/02/1970 at 00:00. It's just a bug bpo-29097 in the Python Windows version. By switching from time.mktime to calendar.timegm, we have already bypassed the bug. Just use normal calendar.timegm((1970, 1, 1, 0, 0, 0, 3, 1, 0)).
Also, 01/02/1970 is (1970, 1, 2, 0, 0, 0, 4, 2, 0), and we can always use 0 instead.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
Participants
Activity
douniwan5788 commentedon Oct 5, 2024
And The
datetimeobject was not given any timezone information. Therefore, the%zin thestrfformat is always empty.gpotter2 commentedon Oct 6, 2024
Is there a bug? This is a bug tracker.
douniwan5788 commentedon Oct 7, 2024
This is the bug
gpotter2 commentedon Oct 8, 2024
Unless you can provide a reproducible example of failing code, and what's expected, I don't consider this a bug.
douniwan5788 commentedon Oct 8, 2024
Well... How to provide a reproducible example of code that never executes?
gpotter2 commentedon Oct 8, 2024
If this does not cause any bug that has some sort of effect in the real world, it's not an issue and likely a waste of time.
I agree that Scapy contains code that is suboptimal, but don't open issues for code that you simply "don't like" yet works fine. For issues like that, my stance would rather be "make a PR or don't bother".