Skip to content

Enhanced to support for multiple repositories #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

neeraj97
Copy link

@neeraj97 neeraj97 commented Apr 6, 2020

Changed to support for multiple repositories and topic (issue #2).

HttpClient is used for http calls. Did not create static HttpClient because HttpClient should be closed for freeing resources when no longer required , but HttpClient cannot be closed if static as there might be other task using it. So I used single HttpClient per task and is closed when task is stopped.

@simplesteph
Copy link
Owner

this is really nice thank you. I won't be able to merge this unfortunately as this wouldn't match the video content I recorded while creating this connector, but I'm happy if you want to leave the PR opened or create a fork for your own repository

@neeraj97 neeraj97 marked this pull request as ready for review April 6, 2020 10:59
@neeraj97
Copy link
Author

neeraj97 commented Apr 6, 2020

this is really nice thank you. I won't be able to merge this unfortunately as this wouldn't match the video content I recorded while creating this connector, but I'm happy if you want to leave the PR opened or create a fork for your own repository

Github has deprecated the username , password authentication and will soon not support it.
kindly refer below :
https://developer.github.com/changes/2020-02-14-deprecating-password-auth/
https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/
Just informing you to keep the video updated at that time.

@simplesteph
Copy link
Owner

you rock, thank you!

@neeraj97
Copy link
Author

neeraj97 commented Apr 6, 2020

you rock, thank you!

It's because you are my teacher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants