Skip to content

Migrate SpringBeanContainer to org.springframework.orm.jpa.hibernate package for Hibernate ORM 7.0 #46210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

lesiak
Copy link

@lesiak lesiak commented Jun 25, 2025

Fixes #46209

@lesiak lesiak marked this pull request as draft June 25, 2025 19:39
@lesiak lesiak marked this pull request as draft June 25, 2025 19:39
@lesiak lesiak changed the base branch from main to 4.0.x June 25, 2025 19:41
@lesiak lesiak marked this pull request as ready for review June 25, 2025 19:42
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 25, 2025
@wilkinsona
Copy link
Member

Thanks for the PR, but there's more that needs to be done to adjust to the changes to Framework's Hibernate support. There's also a problem with persistence exception translation that we're investigating at the moment with the Framework team.

@wilkinsona wilkinsona closed this Jun 25, 2025
@wilkinsona wilkinsona added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 25, 2025
@lesiak
Copy link
Author

lesiak commented Jun 26, 2025

@wilkinsona I completely understand that more changes may be required to support Hibernate 7, but currently spring-boot-autoconfigure module does not even compile due to upstream change in spring-projects/spring-framework#35111.

@bclozel
Copy link
Member

bclozel commented Jun 26, 2025

@lesiak the relevant changes are already on the main branch. I see now that this PR was submitted against 4.0.x.

@lesiak
Copy link
Author

lesiak commented Jun 26, 2025

Indeed, it seems 19818fb was added with identical change after rejecting this PR.

@bclozel
Copy link
Member

bclozel commented Jun 26, 2025

I don't think so.

@lesiak
Copy link
Author

lesiak commented Jun 26, 2025

I guess we both have better things to do than comparing timestamps (but I'm pretty sure about the order of events)

Hope you'll merge this change to 4.x soon.

@wilkinsona
Copy link
Member

wilkinsona commented Jun 26, 2025

@lesiak FWIW, I hadn't seen this PR when I began working on the changes in response to a heads-up from the Framework team. I only noticed it once I had identified the problem with persistence exception translation that needed to be fixed on the Framework side. By that point, it was apparent that the change proposed here wasn't sufficient which is when I made the comment above.

Hope you'll merge this change to 4.x soon.

There's no need to do that. The 4.0.x branch was temporary and has now been deleted. main is producing 4.0.0-SNAPSHOT builds and contains the necessary changes already.

@lesiak
Copy link
Author

lesiak commented Jun 26, 2025

@wilkinsona Thanks for the clarification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate orm.hibernate5 to orm.jpa.hibernate package for Hibernate ORM 7.0
4 participants