-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Return ConsumerStoppedEvent with Abnormal reason when MLC stopped abn… #3949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
926b75f
to
057c8c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: AlamuriLokesh
Please, consider to fix your Git client to provide your official name.
According to DCO, the legal obligations for contributed code has to be from official name, not nicknames.
Otherwise we cannot review and accept your change.
515211d
to
e2626ed
Compare
Could you please review now. I have updated my name as |
spring-kafka/src/main/java/org/springframework/kafka/event/ConsumerStoppedEvent.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments. We need to add reference docs for this since this is a new addition.
spring-kafka/src/main/java/org/springframework/kafka/event/ConsumerStoppedEvent.java
Show resolved
Hide resolved
spring-kafka/src/main/java/org/springframework/kafka/event/ConsumerStoppedEvent.java
Show resolved
Hide resolved
...ng-kafka/src/main/java/org/springframework/kafka/listener/KafkaMessageListenerContainer.java
Show resolved
Hide resolved
...rc/test/java/org/springframework/kafka/listener/ConcurrentMessageListenerContainerTests.java
Show resolved
Hide resolved
b95e9f3
to
cff0e99
Compare
…ormally Signed-off-by: Alamuri Lokesh <alamuri.lokesh@infosys.com>
cff0e99
to
e14e6c2
Compare
…ormally