fix: Add linting rule to enforce unused parameter rule #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehtarac
commented
Jun 9, 2025
zastrowm
requested changes
Jun 11, 2025
| @@ -626,7 +624,7 @@ def test_agent_tool_tool_does_not_exist(agent): | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("tools", [None, [tool_decorated]], indirect=True) | |||
| def test_agent_tool_names(tools, agent): | |||
| def test_agent_tool_names(agent): | |||
There was a problem hiding this comment.
The pytest parametrize attribute still references tools here - is that expected?
Is it still doing what it should be doing in that case?
| @@ -119,6 +119,7 @@ def test__init__with_region_and_session_raises_value_error(): | |||
|
|
|||
| def test__init__default_user_agent(bedrock_client): | |||
| """Set user agent when no boto_client_config is provided.""" | |||
| _ = bedrock_client | |||
There was a problem hiding this comment.
Can we turn this into an autofixture instead or use usefixtures? E.g. is there a reason we need to have it as a parameter or use
| @@ -21,7 +21,7 @@ def run_tools( | |||
| handler: Callable[[ToolUse], ToolResult], | |||
| tool_uses: List[ToolUse], | |||
| event_loop_metrics: EventLoopMetrics, | |||
| request_state: Any, | |||
| _request_state: Any, | |||
There was a problem hiding this comment.
We should just remove this parameter I think? No need to pass it if it's not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a linting rule
ARGthat checks for unused parameters in functions and class methods.Documentation reference : https://docs.astral.sh/ruff/rules/#flake8-unused-arguments-arg
Related Issues
#128
Type of Change
[Choose one of the above types of changes]
Testing
[How have you tested the change?]
hatch fmt --linterhatch fmt --formatterhatch test --allChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.