Skip to content

rdar://154310191 Enable compilation caching for Swift packages #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jansvoboda11
Copy link

This PR enables compilation caching for Swift package targets whenever normal targets have it enabled.

I originally wanted to hook into the SuperimposedProperties machinery and propagate it from normal targets similar to the setting for mergeable libraries. However, some aspects of TargetDependencyResolver made that very hard:

  • treating package targets differently from normal targets (see DiscoveredTargetInfo.immediateDependencies and DiscoveredTargetInfo.packageProductDependencies),
  • not propagating superimposed properties transitively,
  • only visiting nodes in the build graph once (even when the specializations differ).

@jansvoboda11
Copy link
Author

@swift-ci test

@jansvoboda11
Copy link
Author

The build log says the only test failure that's not known is coming from FileHandleTests.asyncReadFileDescriptor(). Let's try again.

@swift-ci test macOS platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant