Fix session lifetime index name in examples #21186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Session index is generated using the lifetime column name, however current the examples are prepending 'sessions' to the generated index name. This results in a migration being created to rename `sessions_sess_lifetime_idx` to `sess_lifetime_idx` after creating the table using the SQL in the docs.
|
Thanks Reio ... and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session index is generated using the lifetime column name.
symfony/symfony@1a67728#diff-fb1dcfa62129a037c11aebcf43264282a5c8e2da5d9409aa8f4f3281659b3dd1R263
However current the examples are prepending 'sessions_' to the generated index name.
This results in a migration being created to rename
sessions_sess_lifetime_idxtosess_lifetime_idxafter creating the table using the SQL in the docs.