Skip to content
This repository was archived by the owner on Sep 26, 2022. It is now read-only.
This repository was archived by the owner on Sep 26, 2022. It is now read-only.

Add a signal to notify when the teosd.py/TeosDaemon is done with bootstrapping #214

@bigspider

Description

@bigspider
Collaborator

Currently, there is no way of knowing when the TeosDaemon is fully initialized and ready once start is called, therefore the e2e tests just wait for a timeout, which occasionally led to failures like this when the timeout is too short: https://app.circleci.com/pipelines/github/talaia-labs/python-teos/789/workflows/7301bb92-7e0b-4e64-ae1d-bccaef33f89c/jobs/1096

Adding an Event argument to the main() method and to the TeosDaemon constructor would allow for a more reliable synchronization mechanism.
A similar method could be used for all other processes as long as they are run via multiprocessing.Process.

Activity

added this to the v0.1.1 milestone on Sep 10, 2020
self-assigned this
on Sep 10, 2020
bigspider

bigspider commented on Sep 11, 2020

@bigspider
CollaboratorAuthor

I tried to do some work in the 214-bootstrap-signal branch; it's easy to do it using an Event for processes that we create with multiprocessing.Process, but I didn't manage to use a simple method to synchronize with subprocesses created in other ways, like the api process created with gunicorn using popen. I tried to create a pipe using os.pipe, but getting an OSError: [Errno 9] Bad file descriptor when I tried to open it in the child process.

Leaving it for now to work on other issues.

removed their assignment
on Sep 11, 2020
modified the milestones: v0.1.1, v0.2.0 on Sep 14, 2020
linked a pull request that will close this issue on Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @sr-gi@bigspider

      Issue actions

        Add a signal to notify when the teosd.py/TeosDaemon is done with bootstrapping · Issue #214 · talaia-labs/python-teos