-
Notifications
You must be signed in to change notification settings - Fork 66
Open
Labels
cln-pluginStuff related to watchtower-pluginStuff related to watchtower-pluginfeature requestNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
#83 added, amongst other commands, getregistrationreceipt which pulls the latest registration receipt from the wathctower-plugin database.
It'll be nice to add some optional parameters that will allow the user to pick the receipt they are interested in, in case it is not the lattest. The parameters should specify a start and end time, and the receipt (or receipts) that englobe such period should be returned.
Metadata
Metadata
Assignees
Labels
cln-pluginStuff related to watchtower-pluginStuff related to watchtower-pluginfeature requestNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
sr-gi commentedon Feb 6, 2023
@1010adigupta this may be a good issue to start with
1010adigupta commentedon Feb 6, 2023
Okay, will start looking into it immediately.
amitpanwar789 commentedon Mar 2, 2023
@sr-gi can you clarify whether we need to change the schema to add a timestamp column or get a registration receipt on the basis of subscription_start and end?
sr-gi commentedon Mar 2, 2023
The schema has to remain the same, the query needs to add a boundary (start /end) so every receipt within that boundary is returned.
amitpanwar789 commentedon Mar 2, 2023
@sr-gi I will like to work on it, so what should be the format of our optional parameters, I guess we need to filter out it from DB on the basis of subscription_expiry, which is I guess the blocks count till which tower must cover the client. optional parameter can be blocks count. am i thinking in right direction?
sr-gi commentedon Mar 2, 2023
The boundary should be a start and end block, given subscription times are accounted for in blocks.
https://github.com/talaia-labs/rust-teos/blob/master/watchtower-plugin/src/dbm.rs#L53-L54
This should be as straight-forward as adding two additional params to the RPC command, if those are present (both of them) then the DB query must be bounded by them, otherwise we pull the most recent receipt.
ShubhamBhut commentedon Mar 3, 2023
I think I forked worng repo. @sr-gi anyway to fix this now ?
sr-gi commentedon Mar 3, 2023
You have to create a PR against this repo and most likely rebase your base commit
Update talaia-labs#97
Update talaia-labs#97