fix(langchain): trace langchain tool definitions #2978
Merged
+98
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to f8d873f in 1 minute and 32 seconds. Click for details.
- Reviewed
156lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/callback_handler.py:102
- Draft comment:
In the new loop that extracts tool definitions frominvocation_params(lines 102-119), consider adding an inline comment explaining that these attributes are meant to trace tool definitions (name, description, parameters). Also, if neither 'parameters' nor 'input_schema' is provided, the code will end up setting a JSON string 'null' – if that isn’t desired, consider adding a check to avoid setting the attribute in such cases. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The first suggestion about adding a comment is purely informative and doesn't require code changes. The second suggestion about null JSON values is speculative ("if that isn't desired") and doesn't demonstrate a clear problem. The code uses _set_span_attribute which already handles null values appropriately by not setting them. Looking at line 64, there's a check that only sets attributes if value is not None and not empty. The comment about null JSON could be valid if there's a requirement to never have 'null' in span attributes, but I don't have enough context about the requirements. The suggestion for documentation could help future maintainers. While documentation is nice, comments should be reserved for complex logic needing explanation. This code is fairly self-explanatory through good naming. The null handling concern is already addressed by the _set_span_attribute function. The comment should be deleted as it doesn't identify any clear issues requiring code changes. The suggestions are either purely informative or raise speculative concerns that are already handled by existing code.
2. packages/opentelemetry-instrumentation-langchain/opentelemetry/instrumentation/langchain/callback_handler.py:130
- Draft comment:
The change in _set_chat_request (line 130) now passes the original kwargs instead of serialized["kwargs"]. This appears to fix tool definition tracing by accessing the full invocation_params. Ensure that there’s no unintended side-effect if both serialized and direct kwargs are present. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. packages/opentelemetry-instrumentation-langchain/tests/test_tool_calls.py:31
- Draft comment:
The tests now comprehensively verify that tool definitions (name and parameters) are correctly traced in the span attributes for both ChatOpenAI and ChatAnthropic scenarios. Great job! As a minor suggestion, also consider adding tests for edge cases when tool definitions might be missing to ensure robustness. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_eXwZspOTlOZADcip
You can customize 
nirga
approved these changes
Jun 9, 2025
DrishyaDas
pushed a commit
to DrishyaDas/openllmetry
that referenced
this pull request
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2975
feat(instrumentation): ...orfix(instrumentation): ....Important
Adds tracing for Langchain tool definitions by setting span attributes for tool functions and includes tests to verify this behavior.
_set_request_params()incallback_handler.py.test_tool_calls.pyto verify tool function attributes are correctly set in spans.test_tool_calls,test_tool_calls_with_history,test_tool_calls_anthropic_text_block, andtest_tool_calls_anthropic_text_block_and_history.This description was created by
for f8d873f. You can customize this summary. It will automatically update as commits are pushed.