patch messages in thread #12191
Merged
patch messages in thread #12191
+28
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR increases the pagination limit for fetching thread messages from 10 to 30 messages per page in fetchAllThreadMessagesOperationSignatureFactory.ts, improving message loading efficiency.
- Changed
limitparameter from 10 to 30 in/packages/twenty-front/src/modules/activities/emails/graphql/operation-signatures/factories/fetchAllThreadMessagesOperationSignatureFactory.ts - Optimizes performance by reducing API calls needed for threads with less than 60 messages
- Maintains fluid experience while fixing issue where messages weren't fully loading between email and thread views
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
bosiraphael
reviewed
May 21, 2025
...ls/graphql/operation-signatures/factories/fetchAllThreadMessagesOperationSignatureFactory.ts
Outdated
Show resolved
Hide resolved
Contributor
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:57845 This environment will automatically shut down when the PR is closed or after 5 hours. |
bosiraphael
reviewed
May 21, 2025
...dules/command-menu/pages/message-thread/hooks/__tests__/useEmailThreadInCommandMenu.test.tsx
Outdated
Show resolved
Hide resolved
etiennejouan
force-pushed
the
fix-mail-pagination
branch
from
7abcd4c to
bf648e9
Compare
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 2, 2025
abdulrahmancodes
pushed a commit
to abdulrahmancodes/twenty
that referenced
this pull request
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12190