Skip to content

Project list refresh and startup bug fix #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ReDarkTechnology
Copy link

@ReDarkTechnology ReDarkTechnology commented Jan 29, 2024

I encountered some problems and decided to make a fork of it, this is my first pull request so I hope this contribution isn't breaking much

Anyway here's the stuff that I fixed:

  • Adding an editor folder in the settings doesn't refresh the project list (and as the result, the versions are still all red even if the editors are added already)
  • On startup, GetElapsedTime vomits an error: System.ArgumentOutOfRangeException: 'The added or subtracted value results in an un-representable DateTime.' which doesn't let me to even start the program in the first place

I remade the whole GetElapsedTime because that is the main bug I wanted to fix, case scenario is when the date time desync or goes backwards, the DateTime it's trying to display is a minus time, when that happened, I made it to just say "Right now"

System.ArgumentOutOfRangeException: 'The added or subtracted value results in an un-representable DateTime.' is fixed
@unitycoder
Copy link
Owner

thanks, i'll have a look!

@unitycoder
Copy link
Owner

Update Project list after adding editor looks fine, will add it soon.

For the GetElapsed, i did something similar in Dev branch just recently, it also removes the processDot part,
so if you want to have a look or even test if that works for you:
227eac3
(it includes those plural "s" values too)

@ReDarkTechnology
Copy link
Author

Tested it, that fix also works too in that specific case!

@unitycoder
Copy link
Owner

Ok good!
i'll close this one and add the project list refresh manually (not smart enough to merge 1 part of this request : )

it will go into dev branch for now, until i merge back & make new build.

@unitycoder unitycoder closed this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants