fix(types): Allow WatchHandler to be of string type even when used with WatchOptions #9121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btoo
changed the title
|
Thanks for contributing but please do not include changes to dist files in the PR. |
yyx990803
changed the title
yyx990803
requested changes
Dec 1, 2018
btoo
force-pushed
the
watchhandler-string-type
branch
3 times, most recently
from
692de28 to
8d5ac8e
Compare
|
Hi @yyx990803, I've removed the changes to Also, I wanted to let you know I made an additional change to allow for |
…Options fix(types): Allow ComponentOptions.watch to be array of WatchOptionsWithHandler or WatchHandler fix(types): Update types test for watch api to match and extend the options shown in Vue documentation
btoo
force-pushed
the
watchhandler-string-type
branch
from
8d5ac8e to
5cbd88d
Compare
|
Is there any reason this was never merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: