ice/examples: improve error handling and formatting in ping_pong example #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cppcoffee
commented
Jun 23, 2025
cppcoffee
commented
- Replace verbose match statements with ? operator for HTTP request handling
- Fix spacing around else clauses to follow Rust formatting conventions
- Simplify error propagation in remoteAuth POST request flow
cppcoffee
changed the title
- Replace verbose match statements with ? operator for HTTP request handling - Fix spacing around else clauses to follow Rust formatting conventions - Simplify error propagation in remoteAuth POST request flow Signed-off-by: Xiaobo Liu <cppcoffee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.