You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 11, 2022. It is now read-only.
There should probably be a peerDependency on DraftJS at ^0.10.5 similar to how we specify the plugin editor versions that are supported. However, fixing this (and supporting the new parameter in handleBeforeInput) will cause us to rev our peerDependency list; that'd be a bump to major and require folks to upgrade both DraftJS and the Plugin Wapper.
If you're blocked by this, make sure you're using draft-js @ ^0.10.5 and draft-js-plugins-editor @ ^2.1.1.
I'm all for 4.x of this plugin, but it's a small change with some pretty major implications. In the meanwhile, I'll put together a PR here on this fork that includes @elbakerino's changes + updates the peerDependencies. It will push us to 4.0.0 since these changes will be backwards incompatible with draft 0.10 and the 2.x branch of the plugins editor.
Activity
elbakerino commentedon Nov 6, 2019
Just as an information, saw this issue during debugging.
I got the base repo runnning with 0.11 and opened a PR there. Maybe the change helps in this fork also.
Arthur944 commentedon Dec 12, 2019
I have the same issue too
ghost commentedon Jan 30, 2020
I have the same issue too
thecodedrift commentedon Feb 5, 2020
EDIT PR available at #186
There should probably be a
peerDependency
on DraftJS at^0.10.5
similar to how we specify the plugin editor versions that are supported. However, fixing this (and supporting the new parameter inhandleBeforeInput
) will cause us to rev ourpeerDependency
list; that'd be a bump to major and require folks to upgrade both DraftJS and the Plugin Wapper.If you're blocked by this, make sure you're using
draft-js
@^0.10.5
anddraft-js-plugins-editor
@^2.1.1
.I'm all for 4.x of this plugin, but it's a small change with some pretty major implications. In the meanwhile, I'll put together a PR here on this fork that includes @elbakerino's changes + updates the peerDependencies. It will push us to
4.0.0
since these changes will be backwards incompatible with draft 0.10 and the 2.x branch of the plugins editor.@mxstbr could you weigh on on this?